-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add boot_disk_kms_key variable for node pools to GA modules #1371
Conversation
@bharathkkb @Jberlinsky Would you mind taking a look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @r1c0x
Since we are moving this out of beta we should also bump the min supported provider. Looking at the change log this looks like it was added in 4.31.0.
version = ">= 4.29.0, < 5.0" |
…tribute is moving out of beta
Thanks @bharathkkb for the review. The provider version is sorted. |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
@r1c0x |
…erraform-google-modules#1371) * Add boot_disk_kms_key variable for node pools * Update README.md for boot_disk_kms_key variable * Bump min supported version of the provider since boot_disk_kms_key attribute is moving out of beta * re run build * loose match test Co-authored-by: Andrew Peabody <andrewpeabody@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Add support for boot_disk_kms_key for node pools that allows encrypting boot disks with customer-managed encryption keys.
https://cloud.google.com/kubernetes-engine/docs/how-to/using-cmek
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#boot_disk_kms_key